From 64d2b2d70deb54d4ec706faeee8c56500df9277d Mon Sep 17 00:00:00 2001 From: Paul Hameteman Date: Wed, 15 Oct 2025 00:40:41 +0200 Subject: [PATCH] -- FINISH -- Updated TECHDEBT.md with ideas / wishes Added NOTES.md for the pomodoro's --- NOTES.md | 9 +++++++++ TECHDEBT.md | 25 ++++++++++++++----------- 2 files changed, 23 insertions(+), 11 deletions(-) create mode 100644 NOTES.md diff --git a/NOTES.md b/NOTES.md new file mode 100644 index 0000000..8dfd630 --- /dev/null +++ b/NOTES.md @@ -0,0 +1,9 @@ +# Pomodoro's: + +1. Setup project & start of refactor readability (comments, dead code, magic string/numbers) +2. Continue readability (renaming, etc) +3. Refactor: Complexity (long method & using mikado technique for Heading enum) +4. Continue refactor: Complexity duplicate code & mikado heading enum +5. Refactor: Reorder responsibilities (data class & message chain are done using mikado) which triggered most of the + other responsibilities as well. +6. Refactor: Refine abstractions (mostly the data clumps & middle man) diff --git a/TECHDEBT.md b/TECHDEBT.md index 3e8c4a6..9b1b0da 100644 --- a/TECHDEBT.md +++ b/TECHDEBT.md @@ -1,14 +1,10 @@ # TODO -- [x] Refine Abstractions - - [x] long parameter list - - [x] data clump - - [x] primitive obsession - - [x] middle man - -# Mikado -- [x] remove move() from heading - - [x] use position.moveBy in RoverState.move - - [x] add moveBy to Position class +- [ ] Command Pattern for go() + - [ ] Move command consts +- [ ] Parser for Rover.constructor() + - [ ] Move parser consts + - [ ] magic string for ' ' char still in the split +- [ ] Update ktlint check for multiline rule :') # RPP - [ ] Design Patterns @@ -32,6 +28,11 @@ - [x] inappropriate intimacy - [x] data class - [x] message chain +- [x] Refine Abstractions + - [x] long parameter list + - [x] data clump + - [x] primitive obsession + - [x] middle man # Mikado - [x] Clean up constants and private fields @@ -66,4 +67,6 @@ - [x] Replace x, y with Position in Heading.move() - [x] RoverState.move use position - [x] Return position in move() instead of Pair - +- [x] remove move() from heading + - [x] use position.moveBy in RoverState.move + - [x] add moveBy to Position class